Adding mesh gateway, secret, secret value, network, code package and network commands(GET, LIST, DELETE) #141
Conversation
src/sfctl/commands.py
Outdated
| @@ -14,7 +14,7 @@ | |||
| from knack.commands import CLICommandsLoader, CommandGroup | |||
| from knack.help import CLIHelp | |||
| from sfctl.apiclient import create as client_create | |||
| from sfctl.apiclient import mesh_app_create, mesh_volume_create, mesh_service_create, mesh_service_replica_create #pylint: disable=line-too-long | |||
| from sfctl.apiclient import mesh_app_create, mesh_volume_create, mesh_service_create, mesh_service_replica_create, mesh_network_create, mesh_code_package_create, mesh_gateway_create, mesh_secret_create, mesh_secret_value_create #pylint: disable=line-too-long | |||
There was a problem hiding this comment.
Can we break this up into multiple lines?
src/sfctl/custom_secret_value.py
Outdated
|
|
||
|
|
||
| def get_secret_value(client, secret_resource_name, secret_value_resource_name, show_value): | ||
| """structure is meant to make testing easier because testing |
There was a problem hiding this comment.
Can you clarify what is referred to by structure?
There was a problem hiding this comment.
This might not be necessary to say actually, more that on mesh cli it looks like
secret_data = client.get(resource_group_name, secret_name, secret_value_resource_name)
if show_value:
secret_value = client.list_value(resource_group_name, secret_name, secret_value_resource_name)
secret_data.value = secret_value['value']
return secret_data
Which looks simpler but always makes the first request for the general secret info and then an optional request to get the value. But because with how the current generated testing library is set up and only checks against the first request made, by slightly moving it around can check the show value scenario also.
src/sfctl/helps/main.py
Outdated
|
|
||
| helps['mesh code-package'] = """ | ||
| type: group | ||
| short-summary: Gets the logs for the container of the specified code package of the service replica. |
There was a problem hiding this comment.
of the service replica -> for the given service replica
changing up the wording - suggestion only
src/sfctl/helps/main.py
Outdated
|
|
||
| helps['mesh secretvalue'] = """ | ||
| type: group | ||
| short-summary: Get and delete mesh secret value resources |
There was a problem hiding this comment.
secret value -> secretvalue
src/sfctl/helps/secretvalue.py
Outdated
| helps['mesh secretvalue show'] = """ | ||
| type: command | ||
| short-summary: Retrieve the value of a specified version of a secret resource | ||
| long-summary: Retrieve the value of a specified version of a secret resource. |
There was a problem hiding this comment.
Don't repeat the short summary in the long summary. Users will see it repeated right next to each other.
src/sfctl/helps/secretvalue.py
Outdated
| type: command | ||
| short-summary: Retrieve the value of a specified version of a secret resource | ||
| long-summary: Retrieve the value of a specified version of a secret resource. | ||
| Use the --show-value flag to see the actual value |
There was a problem hiding this comment.
I would leave the parameter descriptions out unless you feel that it would be very beneficial for the users to see this info here.
src/sfctl/helps/secretvalue.py
Outdated
| package to | ||
| - name: --show-value | ||
| type: bool | ||
| short-summary: Show file upload progress for large packages |
There was a problem hiding this comment.
Content is incorrect
| short-summary: The name of the secret resource. | ||
| - name: --secret-value-resource-name | ||
| type: string | ||
| short-summary: Version identifier of the secret value |
There was a problem hiding this comment.
I'm not too familiar with this... would it be very obvious to the user where the version would be?
There was a problem hiding this comment.
Yes, when getting any information about a secret value you would know which secret resource/secret value you want specifically. List secretvalue would let you look for potential secret values of a secret resource.
src/sfctl/params.py
Outdated
| with ArgumentsContext(self, 'mesh secretvalue show') as arg_context: | ||
| arg_context.argument('secret_resource_name') | ||
| arg_context.argument('secret_value_resource_name') | ||
| arg_context.argument('show_value', required=False) |
There was a problem hiding this comment.
don't need to add required=false. It should be automatic because you provide a default value in the function signature - can you double check pls? thanks!
Fixes # .
Changes include:
GET/LIST/DELETE Commands for gateway, secret/secret value, network, and code package(Only get)
Verified: