Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where empty directories are generated in the current location… #167

Merged

Conversation

Christina-Kang
Copy link
Contributor

@Christina-Kang Christina-Kang commented Dec 11, 2018

… of the command line

In sfctl 7.0.0, there are empty directories generated on sfctl invocation to the location of the command line. This is caused by an upgrade in knack versions. For the 7.0.0 release, sfctl upgraded the knack dependency from 0.1.1 to 0.5.1, and the new issue emerged. The fix is to expand the paths to that sfctl finds the correct location and generates a new folder there, if necessary.

Update for release 7.0.1

Verified:

  • Build and test CI passes
  • History and readme updated to reflect changes
  • Package version updated according to semantic versioning rules
  • Tests modified or added, when applicable
  • Updated code owners file, when applicable
  • Read the PR checklist

@coveralls
Copy link

coveralls commented Dec 11, 2018

Coverage Status

Coverage decreased (-0.09%) to 83.734% when pulling 482ac05 on Christina-Kang:fix-new-file-generation into c6c5106 on Microsoft:master.

@Christina-Kang Christina-Kang merged commit 042c2f9 into microsoft:master Dec 11, 2018
@Christina-Kang Christina-Kang deleted the fix-new-file-generation branch December 11, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants