Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update knack #181

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Update knack #181

merged 2 commits into from
Feb 14, 2019

Conversation

Christina-Kang
Copy link
Contributor

@Christina-Kang Christina-Kang commented Feb 14, 2019 •
edited
Loading

Update knack to the latest version to incorporate some security updates.

Verified:

  • Build and test CI passes
  • History and readme updated to reflect changes
  • Package version updated according to semantic versioning rules
  • Tests modified or added, when applicable
  • Updated code owners file, when applicable
  • Read the PR checklist

jeffj6123
jeffj6123 previously approved these changes Feb 14, 2019
View reviewed changes
@Christina-Kang Christina-Kang merged commit 2487d6c into microsoft:master Feb 14, 2019
@coveralls
Copy link

coveralls commented Feb 15, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 83.198% when pulling 339ab86 on Christina-Kang:update-knack into 6e0692e on Microsoft:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffj6123 jeffj6123 jeffj6123 left review comments

@samedder samedder Awaiting requested review from samedder samedder is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Christina-Kang @coveralls @jeffj6123