Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can’t compile SampleAppLib in scratch islands #10493

Closed
BreeceW opened this issue Jun 22, 2021 · 1 comment · Fixed by #10494
Closed

Can’t compile SampleAppLib in scratch islands #10493

BreeceW opened this issue Jun 22, 2021 · 1 comment · Fixed by #10494
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@BreeceW
Copy link
Contributor

BreeceW commented Jun 22, 2021 •
edited
Loading

Looks like the exact same problem that affected the real app: #10335
Replicating that PR in the scratch folder lets it build and run successfully. I’ll submit a PR to make the same change for SampleAppLib.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 22, 2021
@BreeceW BreeceW mentioned this issue Jun 22, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Jun 22, 2021
@lhecker lhecker added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. labels Jun 22, 2021
@ghost ghost closed this as completed in #10494 Jun 23, 2021
@ghost ghost removed the In-PR This issue has a related PR label Jun 23, 2021
ghost pushed a commit that referenced this issue Jun 23, 2021
@BreeceW
Replicate winrt::make<> changes in ScratchIslandApp SampleAppLib (#10494
848e353 
)

Sample scratch app would not compile. It does if we apply #10335 to App.base.h in the scratch app.

Closes #10493
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jun 23, 2021
@ghost
Copy link

ghost commented Jul 14, 2021

🎉This issue was addressed in #10494, which has now been successfully released as Windows Terminal Preview v1.10.1933.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replicate winrt::make<> changes in ScratchIslandApp SampleAppLib BreeceW/terminal
2 participants
@lhecker @BreeceW