Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "Quit" action #11081

Closed
zadjii-msft opened this issue Aug 30, 2021 · 1 comment · Fixed by #11143
Closed

Add a "Quit" action #11081

zadjii-msft opened this issue Aug 30, 2021 · 1 comment · Fixed by #11143
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.12

Comments

@zadjii-msft
Copy link
Member

If you're already messing around in the area, I might also toss out the idea of a "Quit" action. (We don't have an issue tracking this, but we've mentioned it a pile of times as a team). This is like the "Close Microsoft Edge" button:
image
Or "Exit" in sublime:
image

It's just a simple action to close all the windows, which also then triggers the "save all windows" behavior. A little more straightforward than "killing it in task manager" 😛

Originally posted by @zadjii-msft in #10972 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 30, 2021
@zadjii-msft zadjii-msft added Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Aug 30, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 30, 2021
This was referenced Aug 30, 2021
Merged
Open
@Rosefield Rosefield mentioned this issue Sep 4, 2021
Merged
3 tasks
@ghost ghost closed this as completed in #11143 Sep 9, 2021
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 9, 2021
ghost pushed a commit that referenced this issue Sep 9, 2021
@Rosefield
Add the ability to quit all terminal instances (#11143)
bee6fb4 
Add the ability to quit all terminal instances. Doing this separately from the window layout saving ones to lessen the number of 1k+ line monsters I make y'all review.

## References
#11083 

## PR Checklist
* [x] Closes #11081
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [x] Schema updated.

## Detailed Description of the Pull Request / Additional comments
- Warn the user before they do so to give a chance to cancel
- Percolate a QuitAll event up to the monarch who then directs each peasant to clsoe.
- Leave a window-layout-saving-sized hole to add that feature on top

## Validation Steps Performed
- quit with one window (from the monarch)
- quit from the monarch with multiple windows
- quit from a peasant
- cancel the quit dialog

![image](https://user-images.githubusercontent.com/6185249/132105775-3310f614-ce55-4454-9718-ef5c0d39fbd2.png)
@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #11143, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging a pull request may close this issue.

Add the ability to quit all terminal instances Rosefield/terminal
1 participant
@zadjii-msft