Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling errors w/in source #4294

Closed
jsoref opened this issue Jan 19, 2020 · 1 comment · Fixed by #4295
Closed

Spelling errors w/in source #4294

jsoref opened this issue Jan 19, 2020 · 1 comment · Fixed by #4295
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Console Backlog

Comments

@jsoref
Copy link
Contributor

jsoref commented Jan 19, 2020

Environment

none.

Steps to reproduce

Run a spell checker on the corpus

Expected behavior

Preferably 0 identifiable spelling mistakes.

Actual behavior

tokens including: Constucts and seperate
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 19, 2020
@jsoref jsoref mentioned this issue Jan 19, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Jan 19, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 23, 2020
@DHowett-MSFT
Copy link
Contributor

I'm pulling the triage tag on this since you have a pull request out for it. Thanks for looking into this!

@DHowett-MSFT DHowett-MSFT added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Meta The product is the management of the products. labels Jan 23, 2020
@ghost ghost removed Needs-Tag-Fix Doesn't match tag requirements Help Wanted We encourage anyone to jump in on these. labels Jan 23, 2020
@DHowett-MSFT DHowett-MSFT added this to the Console Backlog milestone Jan 23, 2020
@ghost ghost closed this as completed in #4295 Feb 10, 2020
ghost pushed a commit that referenced this issue Feb 10, 2020
@jsoref
Fix a bunch of spelling errors across the project (#4295)
a13ccfd 
Generated by https://github.com/jsoref/spelling `f`; to maintain your repo, please consider `fchurn`

I generally try to ignore upstream bits. I've accidentally included some items from the `deps/` directory. I expect someone will give me a list of items to drop, I'm happy to drop whole files/directories, or to split the PR into multiple items (E.g. comments/locals/public).

Closes #4294
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 10, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Console Backlog
Development

Successfully merging a pull request may close this issue.

Fix a bunch of spelling errors across the project jsoref/terminal
2 participants
@jsoref @DHowett-MSFT