Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing Windows Terminal changes the behavior of Start menu #7122

Closed
oruponu opened this issue Jul 30, 2020 · 29 comments
Closed

Installing Windows Terminal changes the behavior of Start menu #7122

oruponu opened this issue Jul 30, 2020 · 29 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release Tracking-External This bug isn't resolved, but it's following an external workitem.

Comments

@oruponu
Copy link

oruponu commented Jul 30, 2020

Environment

Windows build number: 10.0.19041.0
Windows Terminal version (if applicable): 1.1.2021.0

Steps to reproduce

  1. Open Start menu.
  2. Click on pinned folder tile or click on folder icon in the bottom left corner (Documents, Pictures, etc.) to open it.
    Settings icon in the bottom left corner and Application tiles are not affected.

Expected behavior

Start menu will automatically close and Explorer will open.

Actual behavior

Start menu will remain open and Explorer will open.


I uninstall Windows Terminal and confirmed that Start menu works as expected.
I also confirmed that the same issue occurs on other computers.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 30, 2020
@zadjii-msft
Copy link
Member

Well that's totally crazy. I don't have the faintest idea why that might happen. I also can't repro this locally, so I can't really investigate this further. Did this happen with previous version of the Terminal? Or only after upgrading to 1.1?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Product-Terminal The new Windows Terminal. labels Jul 31, 2020
@fran-f
Copy link

fran-f commented Jul 31, 2020

I can see this on two different PCs. I think both are running Windows 10.0.18363.959.

The issue appears with Terminal 1.1, installed from store or package, but not with 1.0 (at least installed with package). It presents itself immediately after installation, no need to launch Terminal once.

(Unfortunately I also discovered that if you uninstall Terminal your configuration is deleted...)

@DHowett
Copy link
Member

DHowett commented Jul 31, 2020

This is wild. I can reproduce this! As stated, it only repros with 1.1+, and I have the sneaking suspicion that it's related to the shell extension.

Seems like a platform issue. I'll see if I can set up a minimal repro.

@DHowett DHowett added Tracking-External This bug isn't resolved, but it's following an external workitem. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 31, 2020
@DHowett DHowett self-assigned this Jul 31, 2020
@DHowett DHowett removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. labels Jul 31, 2020
@fran-f

This comment has been minimized.

@DHowett

This comment has been minimized.

@fran-f
Copy link

fran-f commented Jul 31, 2020

I see! Then it's active, I can see the entry right-clicking on directories. However I can't find it in ShellExView, so I can't try to disable it.

@DHowett
Copy link
Member

DHowett commented Jul 31, 2020

Yeah, packaged shell extensions are (we're learning!) very unusual. Somebody suggested a workaround (to disable it) here: #7008 (comment). You'll almost certainly need to restart Explorer.

@fran-f
Copy link

fran-f commented Jul 31, 2020

Following that workaround caused a curious restart loop in Explorer, but after a logout the extension is disabled, and the issue with the start menu is gone.

@DHowett
Copy link
Member

DHowett commented Jul 31, 2020

Thanks for confirming!

@oruponu
Copy link
Author

oruponu commented Aug 1, 2020

Thank you.
I have also confirmed that the Start menu works as expected with that workaround.

@fran-f
Copy link

fran-f commented Aug 29, 2020

As a shortcut to enable or disable the shell extension, one can use a .reg file. I can't upload them to GitHub, but I'll dump them here if anyone needs them. Create the file you need and run it to apply the changes to the Registry.

disable-windows-terminal-shell-extension.reg

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Shell Extensions\Blocked]
"{9F156763-7844-4DC4-B2B1-901F640F5155}"="WindowsTerminal"

re-enable-windows-terminal-shell-extension.reg

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Shell Extensions\Blocked]
"{9F156763-7844-4DC4-B2B1-901F640F5155}"=-

@zadjii-msft
Copy link
Member

Just linking this to the internal thread: MSFT:32962688

@Ronald-G-Andrade
Copy link

Hello dear friends, just a reminder that this bug is still present in the latest stable version (v1.10.2383.0).
Click to open a pinned folder in the start menu (also in full-screen mode) won't close it.
Thank you very much 👍🏻

@zadjii-msft
Copy link
Member

Yep. There's nothing the Terminal can do about this, it's a Start Menu bug. We'll make sure to update this thread when there is anything to share. The internal bug is still open, but this also doesn't repro on Windows 11 anymore, so I'd bet that this isn't something that ends up getting serviced back to Windows 10.

@stjpInd
Copy link

stjpInd commented Nov 26, 2021

I haven't done any extensive testing, but it looks like the issue might be fixed now!
I'm currently on Windows 10 build 19044.1387 with Terminal 1.11.2921.0 installed (no registry workaround) and I don't see the broken Start menu behavior anymore. Pinned folders and search both work as expected.
My suspicion is that Microsoft may have fixed the bug around the same time they rolled out the new search with dark mode, but I couldn't say for certain.

@Ronald-G-Andrade
Copy link

I haven't done any extensive testing, but it looks like the issue might be fixed now! I'm currently on Windows 10 build 19044.1387 with Terminal 1.11.2921.0 installed (no registry workaround) and I don't see the broken Start menu behavior anymore. Pinned folders and search both work as expected. My suspicion is that Microsoft may have fixed the bug around the same time they rolled out the new search with dark mode, but I couldn't say for certain.

It's true dear brother. I tested it and now it's working properly on Windows, either an app or folder, it opens normally by closing the start menu / start screen.

Now, I really hope that Microsoft won't mess up again, later we would fix it and say: ""A new feature"" jajaja

@zadjii-msft
Copy link
Member

Alrighty folks, looks like the explorer team looked into this and found that it doesn't repro on Windows 11, so it must have been fixed as part of the Start Menu rejuvenation. Impossible to say which changelist as a part of that would have fixed this, so it's not gonna be possible to service that fix to Windows 10. Sorry about that.

If folks are seeing this on Windows 11 builds, ping us here on this thread and I can reopen the investigation with the explorer folks.

Thanks!

@zadjii-msft zadjii-msft added the Resolution-Fix-Available It's available in an Insiders build or a release label Apr 5, 2022
@pgorod
Copy link

pgorod commented Apr 5, 2022

Microsoft will continue to support at least one Windows 10 release until October 14, 2025.

... plus the usual years-long delays.

Is this really proper to just ditch Windows 10 bugs as "won't fix" at the current time? Isn't it too early for that?

This saddens me, this bug is really annoying, and it's not even something that only happens inside Windows Terminal, it affects the general OS experience. I am enjoying Terminal but this is making me seriously consider uninstalling it. Please reconsider.

@DHowett
Copy link
Member

DHowett commented Apr 5, 2022

Please reconsider.

Unfortunately, it's just not our call. We only own the Terminal, the console subsystem, and the console driver... not parts of explorer or the start menu or the taskbar. We only have so much power over our peers. 😄

@pgorod
Copy link

pgorod commented Apr 5, 2022

Ok, fair enough, at least you can try telling them "people are complaining that there are still years of support for Windows 10 to exhaust before you get a right to start dropping bugs"

Windows 10 is not open-source and free, it's a commercial product that we paid for.

@merrickjeff
Copy link

Microsoft will continue to support at least one Windows 10 release until October 14, 2025.

... plus the usual years-long delays.

Is this really proper to just ditch Windows 10 bugs as "won't fix" at the current time? Isn't it too early for that?

This saddens me, this bug is really annoying, and it's not even something that only happens inside Windows Terminal, it affects the general OS experience. I am enjoying Terminal but this is making me seriously consider uninstalling it. Please reconsider.

@pgorod Either of these fixes should work unless you really need that context menu:
#7008 (comment)
#7122 (comment)

@hello-smile6

This comment was marked as off-topic.

@DHowett

This comment was marked as off-topic.

@DHowett
Copy link
Member

DHowett commented Apr 5, 2022

at least you can try telling them "people are complaining that there are still years of support for Windows 10 to exhaust before you get a right to start dropping bugs"

Sure can try!

@hello-smile6

This comment was marked as off-topic.

@dymanoid
Copy link

dymanoid commented Apr 10, 2022

Unfortunately, the suggested workarounds described above (disabling the wt shell extension) didn't work for me.
I can confirm there's no "Open in Windows Terminal" context menu item anymore, but the Start menu behavior is still broken (Windows 10 21H2 19044.1586).
I recently installed Visual Studio 2022 Community though, so there might be some other shell extensions causing this behavior. (It might be a coincidence, but I don't observe this behavior on another Windows 10 machine having Windows Terminal but no Visual Studio 2022 installed.)

@FalconFour
Copy link

I didn't even know there was a "open Terminal here" shell extension. I don't even use Windows Terminal - I just had it installed passively -- my habit is still to press the Windows key, type the letters "cmd", and hit Enter or Ctrl+Shift+Enter. Which, on random computers, for months now, had occasionally resulted in cmd (or any other application I open from the start menu) opening up, behind the start menu, leaving me to additionally close the start menu -- or worse, start interacting with the start menu with the keyboard instead of the application (I work very quickly sometimes - this usually happens in the span of 1 second or so).

So, Terminal was identified as the reason for this, eh? And the Terminal folks are like, "😊 haha well it's a Windows bug, we can't fix it"?

I had to become frustrated enough with this issue to even find a way to phrase it to search it - and then trust the absurd conclusion that an app I never use was causing it, and try uninstalling it (which fixed it, btw).

Thus, Terminal breaks Windows in a fairly ridiculous way, that makes it impossible to track down that it's the cause -- it makes a pretty serious case for "just don't use Terminal"! And I'm extremely happy to take that solution, since I didn't even use the software anyway!

What you DO have control over is not installing this "open terminal here" extension unless the user asks for it (I would absolutely not have wanted it), especially given the nature of this bug -- having been open for well over a year now, unmoved.

@michaelbunney
Copy link

So the fix for the Windows 10 Start menu bug is to switch to Windows 11, which has stripped the Start menu of its most useful features? Guess I'll just live without Windows Terminal, because I can't live with Windows 11's version of the Start menu.

@WagnerGFX
Copy link

Microsoft will continue to support at least one Windows 10 release until October 14, 2025.

... plus the usual years-long delays.
Is this really proper to just ditch Windows 10 bugs as "won't fix" at the current time? Isn't it too early for that?
This saddens me, this bug is really annoying, and it's not even something that only happens inside Windows Terminal, it affects the general OS experience. I am enjoying Terminal but this is making me seriously consider uninstalling it. Please reconsider.

@pgorod Either of these fixes should work unless you really need that context menu: #7008 (comment) #7122 (comment)

For those who really need the context menu (like me), I created a custom version in the registry that should do the same work, but without breaking the Start menu.

Just be mindful that this solution:

  1. Uses the Windows Powershell icon.
  2. Requires the "wt" alias, that only exist with the default Terminal installation.
  3. Will open in new tabs, whenever possible.

Customize as needed. Windows Terminal CLI arguments

Windows Terminal - Win10 Context Menu - Custom (Add).reg

Windows` Registry Editor Version 5.00

[HKEY_CLASSES_ROOT\Directory\Background\shell\WindowsTerminal]
@="Open Terminal here"
"Icon"="C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe"

[HKEY_CLASSES_ROOT\Directory\Background\shell\WindowsTerminal\command]
@="wt -w 0 nt -d \"%v\""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Development

No branches or pull requests