Don't dispatch the Toggle Command Palette action to keep the just closed Command Palette closed. #10423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed command palette closed.
ghost
added
Area-CmdPal
ghost
requested review from
zadjii-msft,
miniksa,
DHowett,
leonMSFT,
PankajBhojwani and
lhecker
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
lhecker
approved these changes
Jun 14, 2021
DHowett
pushed a commit
that referenced
this pull request
Jul 7, 2021
…sed Command Palette closed. (#10423) An exception was introduced for the 'Toggle Command Palette' action to **not** being dispatched. Otherwise the command palette that was just closed will become visible again. ## PR Checklist * [x] Closes #10240 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Detailed Description of the Pull Request / Additional comments - Selecting the `Toggle command palette` item in the command palette will now properly close the command palette. - Opening and closing the Command Palette through shortcut keys is still working fine. - Other command palette items are still working fine as well. (cherry picked from commit 813f385)
DHowett
pushed a commit
that referenced
this pull request
Jul 7, 2021
…sed Command Palette closed. (#10423) An exception was introduced for the 'Toggle Command Palette' action to **not** being dispatched. Otherwise the command palette that was just closed will become visible again. ## PR Checklist * [x] Closes #10240 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Detailed Description of the Pull Request / Additional comments - Selecting the `Toggle command palette` item in the command palette will now properly close the command palette. - Opening and closing the Command Palette through shortcut keys is still working fine. - Other command palette items are still working fine as well. (cherry picked from commit 813f385)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exception was introduced for the 'Toggle Command Palette' action to not being dispatched. Otherwise the command palette that was just closed will become visible again.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Toggle command paletteitem in the command palette will now properly close the command palette.