-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a more detailed Device Attributes report #14906
Conversation
a891fe9
to
484d331
Compare
I really don't know what to do with this. It seems that sending a And I don't think adding a timeout is a realistic solution, because then we've just introduced a startup delay for this use case, which I don't think is acceptable. We could pass a parameter telling conhost it's safe to make a For that matter, I'm not sure why we didn't do that with the At this point I'm starting to think I should forget about trying to make this work over conpty and at least get the I should also mention that I'd hoped this process could serve as a model for querying other information from the conpty client, like the color table and cursor style. That would allow to support additional querying operations which aren't currently possible. The proposed screen reader But maybe the long term solution is that we need to get the passthrough mode working, and just live with current conpty limitations in the mean time. |
484d331
to
8a9e34d
Compare
8a9e34d
to
186d8f1
Compare
I've now dropped the feature testing on the conpty client and simply hardcoded the This means that we could we reporting soft font support for some terminals that don't have that, but that seems like the least worst option at this point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM! Sorry we let this one sit for so long!
This is an update of our Primary Device Attributes report, which better
indicates the feature extensions that we now support.
Detailed Description of the Pull Request / Additional comments
This first parameter of the response is 61, representing a conformance
level of 1. The subsequent parameters identify the supported feature
extensions.
1 = 132 column mode
6 = Selective erase
7 = Soft fonts
22 = Color text
23 = Greek character sets
24 = Turkish character sets
28 = Rectangular area operations
32 = Text macros
42 = ISO Latin-2 character set
Most of these features are handled entirely within
AdaptDispatch
, sothey apply to all clients. However, 132 column mode is only supported by
ConHost, so we don't report that for conpty clients.
And note that soft fonts won't necessarily work in all conpty clients,
but we don't have an easy way of determining that, so we just report
soft font support for everyone.
Validation Steps Performed
I've manually verified that the
DA1
report is returning the expectedresponse in Vttest, both from ConHost and Windows Terminal.
I've also updated the
DeviceAttributesTests
in the adapter tests toaccount for the new expected response.
Closes #14491