[pcl] build failure

[Bzz2745]

Operating system

windows 11

Compiler

MSVC

Steps to reproduce the behavior

`./vcpkg install pcl[cuda,surface-on-nurbs,tools,visualization,vtk]`

Failure logs

Installing 1/2 pcl[core,cuda,surface-on-nurbs,tools,visualization,vtk]:[email protected]...
Building pcl[core,cuda,surface-on-nurbs,tools,visualization,vtk]:[email protected]...
-- Using cached PointCloudLibrary-pcl-pcl-1.15.0.tar.gz
-- Cleaning sources at C:/Users/user/opt/vcpkg/buildtrees/pcl/src/pcl-1.15.0-327f82be19.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/user/opt/vcpkg/downloads/PointCloudLibrary-pcl-pcl-1.15.0.tar.gz
-- Applying patch add-gcc-version-check.patch
-- Applying patch fix-check-sse.patch
-- Applying patch fix-numeric-literals-flag.patch
-- Applying patch install-layout.patch
-- Applying patch install-examples.patch
-- Applying patch fix-clang-cl.patch
-- Using source at C:/Users/user/opt/vcpkg/buildtrees/pcl/src/pcl-1.15.0-327f82be19.clean
-- Found external ninja('1.12.1').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
Command failed: C:/Users/user/scoop/apps/cmake/3.31.6/bin/cmake.exe --build . --config Release --target install -- -v -j13
Working Directory: C:/Users/user/opt/vcpkg/buildtrees/pcl/x64-windows-rel
See logs for more information:
C:\Users\user\opt\vcpkg\buildtrees\pcl\install-x64-windows-rel-out.log

Additional context

in file C:\Users\user\opt\vcpkg\buildtrees\pcl\install-x64-windows-rel-out.log, the error is:
C:\Users\user\opt\vcpkg\buildtrees\pcl\src\pcl-1.15.0-327f82be19.clean\visualization\include\pcl/visualization/impl/registration_visualizer.hpp(183): error C2039: 'chrono_literals': is not a member of 'std'
and in file registration_visualizer.hpp chrono_literals was only loaded but not used, if it is useable please add #include to this file.

[mvieth]

@Bzz2745 Could you please specify which MSVC version you use? I would like to try to reproduce this.

[Bzz2745]

@Bzz2745 Could you please specify which MSVC version you use? I would like to try to reproduce this.

VS2022 , do u need the detail version number?

[mvieth]

VS2022 , do u need the detail version number?

@Bzz2745 Yes please, because I am wondering if this only happens with very specific MSVC versions.

[Bzz2745]

VS2022 , do u need the detail version number?

@Bzz2745 Yes please, because I am wondering if this only happens with very specific MSVC versions.

17.13.2

[LiuPeiqiCN]

same issue.

• Host: x64-windows
• Compiler: MSVC 19.43.34808.0
• vcpkg-tool version: 2025-02-11-bec4296bf5289dc9ce83b4f5095943e44162f9c2
  vcpkg-scripts version: 23b33f5 2025-02-26 (24 hours ago)

visual studio version：17.13.1

[LilyWangLL]

I can repro this issue locally.

[mvieth]

I have created a patch:

add-chrono-includes.zip

In my tests, this solved all instances of missing chrono includes, but it would be great if someone else could verify this. Then I can create a pull request to add the patch to the PCL port.
By the way, it seems that this behavior change came with MSVC 17.13, see here under "Improved throughput":

Moved system_clock, high_resolution_clock, and chrono_literals from a commonly-included internal header to <chrono>. microsoft/STL#5105

This has source-breaking impact. If you see compiler errors complaining that it doesn't recognize chrono types like system_clock or UDLs like 1729ms, you need to include <chrono> specifically, instead of assuming that headers like <thread> will drag it in.

[Cheney-W]

@mvieth This patch successfully fixed the issue.