Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] Include <chrono> for system_clock and now #42425

Merged

Conversation

LilyWangLL
Copy link
Contributor

Due to there are new changes merged by microsoft/STL#5105, so port llvm need to include <chrono> by patching to fix the following error for feature llvm[lldb]:

D:\b\llvm\src\org-18.1.6-e754cb1d0b.clean\lldb\tools\lldb-dap\ProgressEvent.h(79): error C2039: 'system_clock': is not a member of 'std::chrono'
D:\b\llvm\src\org-18.1.6-e754cb1d0b.clean\lldb\tools\lldb-dap\ProgressEvent.cpp(134): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\b\llvm\src\org-18.1.6-e754cb1d0b.clean\lldb\tools\lldb-dap\ProgressEvent.cpp(134): error C2039: 'now': is not a member of 'std::chrono'

I have submitted relevant PRs upstream llvm/llvm-project#118059.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 29, 2024
@LilyWangLL LilyWangLL marked this pull request as ready for review December 2, 2024 01:33
@BillyONeal BillyONeal merged commit abd3bf1 into microsoft:master Dec 2, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the fix and submitting upstream!

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Dec 2, 2024
@LilyWangLL LilyWangLL deleted the dev/LilyWang/include-chrono-llvm branch December 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants