Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Copilot hover warning in the ExtensionHost logging. #13316

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

sean-mcmanus
Copy link
Contributor

Fixes [warning] [ms-vscode.cpptools] Accessing a window scoped configuration for a resource is not expected. To associate 'C_Cpp.copilotHover' to a resource, define its scope to 'resource' in configuration contributions in 'package.json'.

It is strange for hover to per-workspace folder and copilot hover to per-workspace, but I don't think it matters, i.e. if enough users complain maybe we could make copilot hover per-workspace folder as well.

@sean-mcmanus sean-mcmanus requested a review from a team as a code owner February 27, 2025 22:02
@sean-mcmanus sean-mcmanus requested a review from spebl February 27, 2025 22:02
@sean-mcmanus sean-mcmanus enabled auto-merge (squash) February 27, 2025 22:28
@sean-mcmanus sean-mcmanus merged commit 60c4434 into main Mar 3, 2025
6 checks passed
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixCopilotHoverWarning branch March 3, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants