Add run notebook in dedicated extension host command #9492
Conversation
src/client/common/serviceRegistry.ts
Outdated
| @@ -88,6 +89,10 @@ export function registerTypes(serviceManager: IServiceManager) { | |||
| IExtensionSingleActivationService, | |||
| ReloadVSCodeCommandHandler | |||
| ); | |||
| serviceManager.addSingleton<IExtensionSingleActivationService>( | |||
There was a problem hiding this comment.
You must have older bits. This folder should exist anymore.
There was a problem hiding this comment.
oh I see, let me rebase
My update from main is in now. I think that at this point we want to go ahead and update package-lock.json. Now that release is branched off it's safe to do so. It would just need to merge due to my package-lock changes. |
Codecov Report
@@ Coverage Diff @@
## main #9492 +/- ##
======================================
Coverage 73% 73%
======================================
Files 191 229 +38
Lines 8854 10524 +1670
Branches 1303 1541 +238
======================================
+ Hits 6482 7746 +1264
- Misses 1857 2149 +292
- Partials 515 629 +114
|
| import { ICommandManager, IWorkspaceService } from '../types'; | ||
|
|
||
| /** | ||
| * Prompts user to reload VS Code with a custom message, and reloads if necessary. |
There was a problem hiding this comment.
Does it actually prompt? I don't see that happening in the code
There was a problem hiding this comment.
not sure why the package-lock is changing.
we have a debt item to address this (@rchiodo @IanMatthewHuff Ajay aware of this issue) please could you revert the changes to the package lock file
|
Updated the package lock. Something is off with linting still. Looking into it quick. |
|
Small tslint fix on the affinity max check. |
Fixes microsoft/vscode#140374
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).