Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a few telemetry points for preview features #18887

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding a few telemetry points for preview features #18887

wants to merge 1 commit into from

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Mar 1, 2025

Adding:

  • "source" for execution plan so we know whether it came from opening a .sqlplan file or from getting the plan for a query
  • state of preview flags upon extension activation

Also fixing a bug where the file extension filter wasn't set right when saving an execution plan

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 51.06% 51.34% $${\color{lightgreen} .28\% }$$
VSIX Size 12984 KB 12982 KB $${\color{lightgreen} -2 KB \space (0\%) }$$
Webview Bundle Size 3188 KB 3188 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewis-sanchez lewis-sanchez lewis-sanchez approved these changes

@kburtram kburtram Awaiting requested review from kburtram kburtram is a code owner

@aasimkhan30 aasimkhan30 Awaiting requested review from aasimkhan30 aasimkhan30 is a code owner

@cssuh cssuh Awaiting requested review from cssuh cssuh is a code owner

@caohai caohai Awaiting requested review from caohai caohai is a code owner

@laurennat laurennat Awaiting requested review from laurennat laurennat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benjin @lewis-sanchez