Fix Results Panel not Refreshing Automatically #670
Conversation
kevcunnane
commented
Feb 3, 2017
kevcunnane
commented
- Fixes Results Panel not Refreshing Automatically #669
- Ensures that TextDocumentContentProvider.provideTextDocumentContent always provides an updated string when being refreshed. In VSCode 1.9.0, it's vital to do this as there is a diff on the provided content and the document is only refreshed if this is different
- Fixes #669 - Ensures that TextDocumentContentProvider.provideTextDocumentContent always provides an updated string when being refreshed. In VSCode 1.9.0, it's vital to do this as there is a diff on the provided content and the document is only refreshed if this is different
|
@kevcunnane, thanks for your PR! By analyzing the history of the files in this pull request, we identified @anthonydresser, @sharonravindran and @kburtram to be potential reviewers. |
|
Hi @kevcunnane, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| @@ -411,13 +411,13 @@ export class SqlOutputContentProvider implements vscode.TextDocumentContentProvi | |||
| public provideTextDocumentContent(uri: vscode.Uri): string { | |||
| // URI needs to be encoded as a component for proper inclusion in a url | |||
| let encodedUri = encodeURIComponent(uri.toString()); | |||
|
|
|||
| // return dummy html content that redirects to 'http://localhost:<port>' after the page loads | |||
| let timeNow = new Date().getTime(); | |||
There was a problem hiding this comment.
Might be good to add a comment referencing a github issue to know why this was done in the future when everyone has forgotten about this problem.
There was a problem hiding this comment.
Good point - updated in latest commit
- Includes version bump
* Switch publisher in telemetry test to ms-mssql (#556) * Switch publisher in telemetry test to ms-mssql * Update a couple more hard-coded publisher references. * Fix Results Panel not Refreshing Automatically (#670) - Fixes #669 - Ensures that TextDocumentContentProvider.provideTextDocumentContent always provides an updated string when being refreshed. In VSCode 1.9.0, it's vital to do this as there is a diff on the provided content and the document is only refreshed if this is different - Updated release version
