Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code action to format code when there's a final new line missing #176

Closed
2 tasks
luabud opened this issue Sep 2, 2022 · 3 comments · Fixed by #218
Closed
2 tasks

Add code action to format code when there's a final new line missing #176

luabud opened this issue Sep 2, 2022 · 3 comments · Fixed by #218
Labels
feature-request Request for new features or functionality good first issue Good for newcomers needs PR

Comments

@luabud
Copy link
Member

luabud commented Sep 2, 2022

Ref: #43

There are two things that needs to be done:

  • Create quick fix for warning code C0304:missing-final-newline that triggers the format document action
  • Add unit test

The code for the first step will be similar to the one here:

@QUICK_FIXES.quick_fix(codes=["C0301:line-too-long"])

And the unit tests will be similar to this:

@github-actions github-actions bot added the triage-needed Issue is not triaged. label Sep 2, 2022
@luabud luabud added feature-request Request for new features or functionality good first issue Good for newcomers needs PR ghc-osd and removed triage-needed Issue is not triaged. labels Sep 2, 2022
@gagandeepp
Copy link

interested please assign

@gagandeepp
Copy link

@luabud @karthiknadig can you please add hacktoberfest label to this repo and issue?

@brettcannon
Copy link
Member

@gagandeepp sorry, but we are purposefully not participating in Hacktoberfest due to multiple years of low-quality PRs because of the event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality good first issue Good for newcomers needs PR
Projects
None yet
3 participants