Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: New line missing code action #200

Closed
wants to merge 2 commits into from
Closed

Fixes: New line missing code action #200

wants to merge 2 commits into from

Conversation

gagandeepp
Copy link

Fixes: #176

Copy link
Member

@karthiknadig karthiknadig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!! Thanks for the PR. I just have one change.

@@ -11,6 +11,8 @@
import traceback
from typing import Any, Callable, Dict, List, Optional, Sequence, Union

from pygls import lsp, protocol, server, uris, workspace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved back to line 39. This will break code otherwise. See the comment on line 37

@karthiknadig karthiknadig requested a review from karrtikr October 19, 2022 17:13
@gagandeepp gagandeepp closed this Oct 20, 2022
@karrtikr karrtikr reopened this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code action to format code when there's a final new line missing
3 participants