Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest template #147

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Update to latest template #147

merged 4 commits into from
Jul 29, 2022

Conversation

karthiknadig
Copy link
Member

  1. Uses proposed API to get python from python extension.
  2. Adds pylint.interpreter setting: allows users to set the interpreter used to launch the server.
  3. Adds pylint.importStrategy setting: allows users to choose between bundled only or environment with bundled fallback.
  4. Adds pylint.showNotification setting: allows users to control when they see the notification.

@karthiknadig
Update to latest extension template. (#144)
80e3531 
* Update packages.

* Python code changes.

* Update package json with new settings.

* Update template.

* Update pr labeling.

* Fix linting.
@karthiknadig
Control where pylint is imported from. (#145)
759572e 
* Improve pylint imports.

* Fix tests.
@karthiknadig
More fixes (#146)
ea268d3 
* Fix issues with running

* Fix linter.
@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Jul 28, 2022
@karthiknadig karthiknadig self-assigned this Jul 28, 2022
karrtikr
karrtikr previously approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're okay with making another release of extension once proposed APIs go away, these suggestions can be skipped. LGTM otherwise.

@karthiknadig
Copy link
Member Author

I will have to make the change in the template repo then propagate it to this PR

@karthiknadig karthiknadig mentioned this pull request Jul 29, 2022
Closed
@karthiknadig karthiknadig merged commit 10bc4c2 into main Jul 29, 2022
@karthiknadig karthiknadig deleted the proposed-api branch July 29, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrtikr karrtikr karrtikr approved these changes

Assignees

@karthiknadig karthiknadig

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karthiknadig @karrtikr