Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get launch config from settings.json as fallback #585

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Feb 5, 2025

fixes #532

@eleanorjboyd eleanorjboyd self-assigned this Feb 5, 2025
@eleanorjboyd eleanorjboyd added the bug Issue identified by VS Code Team member as probable bug label Feb 5, 2025
@eleanorjboyd eleanorjboyd marked this pull request as ready for review February 5, 2025 17:40
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 5, 2025
Copy link
Member

@karthiknadig karthiknadig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion. getConfiguration is already defined in common/vscodeapis. We can just use that.

@eleanorjboyd eleanorjboyd merged commit 84ce2f2 into microsoft:main Feb 13, 2025
16 checks passed
@eleanorjboyd eleanorjboyd deleted the yellow-bagel branch February 13, 2025 16:52
eleanorjboyd added a commit to eleanorjboyd/vscode-python-debugger that referenced this pull request Feb 14, 2025
* get launch config from settings.json as fallback

* update error return

* remove dup getConfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read test debug configuration from settings not just launch.json
2 participants