Display user friendly path when displaying create environment notific…

…ation (#20387) Closes #19934
microsoft · Dec 15, 2022 · 07e334a · 07e334a
1 parent e72ca97
commit 07e334a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/client/extensionActivation.ts b/src/client/extensionActivation.ts
@@ -26,6 +26,7 @@ import {
     IExtensions,
     IInterpreterPathService,
     IOutputChannel,
+    IPathUtils,
 } from './common/types';
 import { noop } from './common/utils/misc';
 import { DebuggerTypeName } from './debugger/constants';
@@ -102,7 +103,8 @@ export function activateFeatures(ext: ExtensionState, _components: Components):
     const interpreterPathService: IInterpreterPathService = ext.legacyIOC.serviceContainer.get<IInterpreterPathService>(
         IInterpreterPathService,
     );
-    registerCreateEnvironmentFeatures(ext.disposables, interpreterQuickPick, interpreterPathService);
+    const pathUtils = ext.legacyIOC.serviceContainer.get<IPathUtils>(IPathUtils);
+    registerCreateEnvironmentFeatures(ext.disposables, interpreterQuickPick, interpreterPathService, pathUtils);
 }
 
 /// //////////////////////////

diff --git a/src/client/pythonEnvironments/creation/createEnvApi.ts b/src/client/pythonEnvironments/creation/createEnvApi.ts
@@ -3,7 +3,7 @@
 
 import { ConfigurationTarget, Disposable } from 'vscode';
 import { Commands } from '../../common/constants';
-import { IDisposableRegistry, IInterpreterPathService } from '../../common/types';
+import { IDisposableRegistry, IInterpreterPathService, IPathUtils } from '../../common/types';
 import { registerCommand } from '../../common/vscodeApis/commandApis';
 import { IInterpreterQuickPick } from '../../interpreter/configuration/types';
 import { getCreationEvents, handleCreateEnvironmentCommand } from './createEnvironment';
@@ -48,6 +48,7 @@ export function registerCreateEnvironmentFeatures(
     disposables: IDisposableRegistry,
     interpreterQuickPick: IInterpreterQuickPick,
     interpreterPathService: IInterpreterPathService,
+    pathUtils: IPathUtils,
 ): void {
     disposables.push(
         registerCommand(
@@ -64,7 +65,7 @@ export function registerCreateEnvironmentFeatures(
         onCreateEnvironmentExited(async (e: CreateEnvironmentResult | undefined) => {
             if (e && e.path) {
                 await interpreterPathService.update(e.uri, ConfigurationTarget.WorkspaceFolder, e.path);
-                showInformationMessage(`${CreateEnv.informEnvCreation} ${e.path}`);
+                showInformationMessage(`${CreateEnv.informEnvCreation} ${pathUtils.getDisplayName(e.path)}`);
             }
         }),
     );