Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configuration file path join on windows #984

Merged
merged 2 commits into from
Apr 13, 2021
Merged

fix: configuration file path join on windows #984

merged 2 commits into from
Apr 13, 2021

Conversation

wengys
Copy link
Contributor

@wengys wengys commented Apr 12, 2021

configuration.ts中,存在一处路径硬拼接问题。可通过以下步骤重现:

于windows平台

  1. npm init midway -- --type=web my_midway_app
  2. npm run dev
  3. 报错了

此提交改为path.join拼接路径

@gitpod-io
Copy link

gitpod-io bot commented Apr 12, 2021

@czy88840616 czy88840616 self-requested a review April 12, 2021 15:08
@codecov-io
Copy link

codecov-io commented Apr 12, 2021

Codecov Report

Merging #984 (44e681d) into 2.x (0a2a4e5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x     #984   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files         203      203           
  Lines        7984     7984           
  Branches     1588     1588           
=======================================
  Hits         6900     6900           
  Misses       1036     1036           
  Partials       48       48           
Impacted Files Coverage Δ
packages/core/src/context/configuration.ts 97.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2a4e5...44e681d. Read the comment docs.

@waitingsong
Copy link
Member

join(`${packageBaseDir}`, 'configuration');

可以不需要使用模板字符功能吧

join(packageBaseDir, 'configuration');

@czy88840616
Copy link
Member

的确是,不需要模版了

@wengys
Copy link
Contributor Author

wengys commented Apr 13, 2021

确实是,昨晚改的不细致

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants