Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix to exception throwing #1

Merged
merged 1 commit into from
Jul 26, 2014
Merged

minor fix to exception throwing #1

merged 1 commit into from
Jul 26, 2014

Conversation

basil-inc
Copy link
Contributor

Got the error "Class 'mikehaertl\pdftk\Exception' not found" upon throwing the exception

Got the error "Class 'mikehaertl\pdftk\Exception' not found" upon throwing the exception
@basil-inc
Copy link
Contributor Author

@mikehaertl by the way: why do you limit the page handles to the letters A-Z?
I am trying to use your library to concatenate a bunch of graphs into a larger PDF, but their number will probably exceed the letters in the alphabet. Why can't it accept any string?

@basil-inc
Copy link
Contributor Author

PS: I really like your code. I also saw you're a contributor to the Yii2 framework, which I am using in my current project. Thanks for sharing your work!

@mikehaertl
Copy link
Owner

why do you limit the page handles to the letters A-Z?

AFAIK that's a limitation of pdftk versions 1.x. I've tried to use more letters and it didn't work.

I also want to add support for 2.x versions, but not quite sure yet, what's the best way here. Need to check all the differences first.

mikehaertl added a commit that referenced this pull request Jul 26, 2014
minor fix to exception throwing
@mikehaertl mikehaertl merged commit b581849 into mikehaertl:master Jul 26, 2014
This was referenced Aug 13, 2018
@MindBreak11 MindBreak11 mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants