Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: storage v2 clang format version 12 #40287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shaoting-huang
Copy link
Contributor

@shaoting-huang shaoting-huang commented Mar 3, 2025

change storage v2 clang-format version from 14 to 12 to match with Milvus.
related: #39173

Signed-off-by: shaoting-huang <[email protected]>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 3, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 3, 2025
Copy link
Contributor

mergify bot commented Mar 3, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 62.85714% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.55%. Comparing base (de02a3e) to head (671ca7b).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/segcore/packed_reader_c.cpp 25.00% 6 Missing ⚠️
internal/core/src/segcore/packed_writer_c.cpp 33.33% 6 Missing ⚠️
internal/core/src/segcore/column_groups_c.cpp 93.75% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40287       +/-   ##
===========================================
+ Coverage   69.88%   80.55%   +10.67%     
===========================================
  Files         309     1475     +1166     
  Lines       27705   207198   +179493     
===========================================
+ Hits        19362   166916   +147554     
- Misses       8343    34233    +25890     
- Partials        0     6049     +6049     
Components Coverage Δ
Client 79.21% <ø> (∅)
Core 69.87% <62.85%> (-0.01%) ⬇️
Go 82.35% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/segcore/arrow_fs_c.cpp 90.69% <100.00%> (+0.22%) ⬆️
internal/core/src/segcore/column_groups_c.cpp 94.11% <93.75%> (+0.78%) ⬆️
internal/core/src/segcore/packed_reader_c.cpp 42.55% <25.00%> (-1.64%) ⬇️
internal/core/src/segcore/packed_writer_c.cpp 68.88% <33.33%> (-4.29%) ⬇️

... and 1166 files with indirect coverage changes

@shaoting-huang
Copy link
Contributor Author

rerun ut

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 3, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@shaoting-huang shaoting-huang changed the title enhance: storage v2 clang format enhance: storage v2 clang format version 12 Mar 3, 2025
Copy link
Contributor

mergify bot commented Mar 3, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor

sunby commented Mar 3, 2025

/lgtm

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 3, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added ci-passed and removed ci-passed labels Mar 3, 2025
Copy link
Contributor

mergify bot commented Mar 3, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 4, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@tedxu
Copy link
Contributor

tedxu commented Mar 4, 2025

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants