Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add metrics for l0 segment rowNum and memSize #40299

Closed

Conversation

weiliu1031
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 3, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from aoiasd and czs007 March 3, 2025 09:08
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 3, 2025
Copy link
Contributor

mergify bot commented Mar 3, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (837ac29) to head (3b83656).
Report is 2 commits behind head on master.

❌ Your project status has failed because the head coverage (69.97%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (837ac29) and HEAD (3b83656). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (837ac29) HEAD (3b83656)
3 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40299       +/-   ##
===========================================
- Coverage   80.53%   69.97%   -10.57%     
===========================================
  Files        1470      309     -1161     
  Lines      206664    27718   -178946     
===========================================
- Hits       166442    19396   -147046     
+ Misses      34177     8322    -25855     
+ Partials     6045        0     -6045     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.97% <ø> (ø)
Go ∅ <ø> (∅)

see 1161 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Mar 3, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the optimize_delete_metrics branch from 7ac8720 to 3b83656 Compare March 4, 2025 06:16
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Mar 4, 2025
Copy link
Contributor

mergify bot commented Mar 4, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031 weiliu1031 closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring component/querynode dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants