Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix storage v2 cgo mem leak #40305

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

shaoting-huang
Copy link
Contributor

related: #39173

Signed-off-by: shaoting-huang <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 3, 2025
@sre-ci-robot sre-ci-robot requested review from sunby and tedxu March 3, 2025 11:37
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 3, 2025
Copy link
Contributor

mergify bot commented Mar 3, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.53%. Comparing base (de02a3e) to head (7aa8ea2).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40305       +/-   ##
===========================================
+ Coverage   69.88%   80.53%   +10.65%     
===========================================
  Files         309     1470     +1161     
  Lines       27705   206760   +179055     
===========================================
+ Hits        19362   166519   +147157     
- Misses       8343    34197    +25854     
- Partials        0     6044     +6044     
Components Coverage Δ
Client 79.16% <ø> (∅)
Core 69.88% <ø> (ø)
Go 82.33% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/storagev2/packed/packed_reader.go 75.51% <100.00%> (ø)
internal/storagev2/packed/packed_writer.go 79.31% <100.00%> (ø)

... and 1159 files with indirect coverage changes

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 4, 2025

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Mar 4, 2025
@tedxu
Copy link
Contributor

tedxu commented Mar 4, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d77756c into milvus-io:master Mar 4, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants