Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: use previous removeDuplicates to keep entry tag order #3159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

revert: use previous removeDuplicates to keep entry tag order #3159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions internal/storage/entry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"errors"
"fmt"
"log/slog"
"slices"
"strings"
"time"

Expand Down Expand Up @@ -612,9 +611,18 @@ func (s *Storage) UnshareEntry(userID int64, entryID int64) (err error) {
return
}

func removeDuplicates(l []string) []string {
slices.Sort(l)
return slices.Compact(l)
// removeDuplicate removes duplicate entries from a slice while keeping order.
// Some feeds expect tags to be shown in order, so we preserve it rather than sort.
func removeDuplicates[T string | int](sliceList []T) []T {
allKeys := make(map[T]bool)
list := []T{}
for _, item := range sliceList {
if _, value := allKeys[item]; !value {
allKeys[item] = true
list = append(list, item)
}
}
return list
}

func removeEmpty(l []string) []string {
Expand Down
Loading