Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #78

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update README.md #78

wants to merge 1 commit into from

Conversation

kburich
Copy link

@kburich kburich commented Feb 13, 2025

Add security badge that highlights code security compliance and enhances project transparency. The badge automatically updates when a new version is published.

https://secure.software/npm/packages/minimist

@ljharb
Copy link
Member

ljharb commented Feb 13, 2025

I’ve checked a few of my packages with that site and am underwhelmed - false positives, and already-fixed vulns show up as somehow being worse than no vulns at all (when in fact that’s better).

I think we’ll pass on this one.

@kburich
Copy link
Author

kburich commented Feb 13, 2025

Thanks for the response. First of all I got to say I love your work and thank you for your contributions to open source!

Would love to hear more about your experience with the site as I am one of the developers working on it. Could you be a bit more specific about what you didn't like?

Your feedback would be much appreciated and I'm confident that we could fix any issue you encountered on our side pretty promptly.

@ljharb
Copy link
Member

ljharb commented Feb 13, 2025

https://secure.software/npm/packages/qs has a "high" issue (that almost surely is a false positive) but there's no way to find out what the issue is or how I can fix it
https://secure.software/npm/packages/resolve has 3 resolved CVEs, and a resolved CVE is a much stronger signal for "secure" than no CVEs at all for any software, so why does it have a scary red exclamation point? same with https://secure.software/npm/packages/forms

then there's a package like https://secure.software/npm/packages/aud which is archived and deprecated, so while there's no known CVEs, if one were discovered it probably wouldn't get fixed, so it definitely should not show up as green/safe/secure.

in other words, it appears like this site is "punishing" packages that have ever had vulnerabilities, when in fact the proper security posture is to assume every single package in existence has vulnerabilities, they're just not all known yet - and evidence that maintainers respond to and resolve vulnerabilities means the package is secure, whereas no evidence whatsoever means its security is unknown.

(also, in general, any reported problem should be clickable and take me to a more detailed explanation of the precise problem in this package, not a generic page describing the category of problem)

@ljharb ljharb marked this pull request as draft February 13, 2025 17:11
@kburich
Copy link
Author

kburich commented Feb 13, 2025

Thank you for the great feedback. We will thoroughly analyze the feedback and I will get back to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants