Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support V10 generated config #1743

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Support V10 generated config #1743

merged 1 commit into from
Dec 22, 2022

Conversation

gtpho
Copy link
Contributor

@gtpho gtpho commented Dec 22, 2022

It's currently not possible to use credentials.NewFileMinioClient with a V10 generated config because it expects hosts instead of aliases. This commit uses aliases if the version is 10.

vadmeste
vadmeste approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 8cfb4c2 into minio:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtpho @vadmeste @harshavardhana