20190101-sha256-optimise #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies, this was intended for the spacemeshos project, not minios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an assembly module and tests for calculating SHA256 hashes using the Intel SHA extensions.
CPU detection logic has been refactored and selection of the best implementation at initialiation.
Platform independent Go code has been optimised as well, delivering significant performance improvements.
Benchmarking code has been reworked to test all supported SHA implementations.
This external module interface is unchanged and it can be dropped into POET as a replacement for minio/sha256-simd.
Note the PR branch is 20190101-sha256-optimise in my repo and it was branch from commit 5197645 which was the current HEAD of minio/sha256-simd (and still is as of now).