Merge pull request #307 from mintel/fix-selector

Fix basic-config template for Service selector
mintel · Jan 13, 2024 · 574f387 · 574f387
2 parents be0f81f + a446952
commit 574f387
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/charts/basic-config/CHANGELOG.md b/charts/basic-config/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [v0.3.1] - 2024-01-12
+### Fixed
+- Fix template for Service selector
+
 ## [v0.3.0] - 2023-06-28
 ### Removed
 - Remove `helm.sh/chart` annotation from all remaining manifests.

diff --git a/charts/basic-config/Chart.yaml b/charts/basic-config/Chart.yaml
@@ -15,4 +15,4 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.3.0
+version: 0.3.1
diff --git a/charts/basic-config/README.md b/charts/basic-config/README.md
@@ -1,6 +1,6 @@
 # basic-config
 
-![Version: 0.3.0](https://img.shields.io/badge/Version-0.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
+![Version: 0.3.1](https://img.shields.io/badge/Version-0.3.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 A Helm chart for defining basic k8s configuration res
 

diff --git a/charts/basic-config/templates/service.yaml b/charts/basic-config/templates/service.yaml
@@ -15,5 +15,5 @@ spec:
   clusterIP: None
   {{- end }}
   type: {{ .Values.service.type }}
-  selector: {{ (toYaml .Values.service.selectorLabelsOverride | nindent 6) | default (include "mintel_common.selectorLabels" .) }}
+  selector: {{ toYaml .Values.service.selectorLabelsOverride | default (include "mintel_common.selectorLabels" .) | nindent 6 }}
 {{- end }}