-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaption to 2.8+ #11
base: master
Are you sure you want to change the base?
Adaption to 2.8+ #11
Conversation
Increasing compatibility to 2.8 by forking popupsubmenuitem and including earlier bugfixes from g to c menu port by another person.
issue regards bluedxca93 |
@bluedxca93 seems to be working perfectly now, thanks again for fixing startkmenu! +1 for merging pull request (if the original author is still even around) |
Hi... Is there a way to put the opened menu to the left border of the screen ? On my computer, even the start button is the first icon on the left, the menu is opened some pixels to the right (about 20... can't count them with a mouse) and there is a space between the left side of the screen and the menu... Thanks for answer. David. |
@bluedxca93: I use StarkMenu with CinnXP Theme. The colors of the username and the descriptions of the applications are very similar. So it is nearly unreadable. Do you know how to fix it. But I don't want the color of the text to be changed. Can you help me with that? |
hi,
not really, i could change the font color to black lighten that one
menu gradient but not more.
b.t.W. its unecessary to move the user name to top. Why? Small ui
differences can be very useful.
regards bluedxca93
|
you have a different applet in mind and im not the right person to ask,
sry. im more specialized in gtk3 and.cinnamon theming than app
writing. Just patched it (know what some lines.of the code do.but not
all ).
a menu where quicklings remain visible when opening menu is easy to
do. but that isn't for user icon. please look in applet source code.
maybe.you can make the changes yourself. All you need is time some
english and a little bit of general computer language knowledge.
|
Okay. Thanks anyway. Could you tell me, how can I change the font color? |
append
.hover-label {
color : #000;
}
to your cinnamon.css and restart. guess that helps for the color.
thx for the improvement with the icon check it next week.
regards bluedxca93
|
To another topic. I found an issue with this menu. If I change the icon theme, StarkMenu does not refresh on its own. That isn't a big deal. Just wanted to mention it. |
hi,
widget:
https://drive.google.com/file/d/0B80SfhWhhiyZbU9YYkY3YkxlcVU/edit?usp=sharing
you did ask for a cinnxp.control theme , maybe this different theme
works better for now (since it was written for ubuntu 14.04 gtk3.10
not 3.18). there are some changes between both versions .
scss means a condensed form of css. after analyzing it, ive found
itmakes sense if you have backdrop and a flat or very logical theme.
3.10 isn't optimized for the necessary changes to minimize source code
like this and so it has slightly different widget classes .
gtk3-widget-factory and file-roller are good applications to demonstrate this.
cinnamon theme:
px gap somewhere padding value in boxpointer?
your changes in menu:
look at them and merge them into my version of stark menu applet fork next week.
regards bluedxca93
|
@bluedxca93: Sorry it is not really clear to me, to whom your last answer belongs? I don't understand your comment: "your changes in menu: Should I look and merge at them or will you? To the CinnXP Control theme. There is now a gtk-3.10 version available. I haven't tried it yet, but will tomorrow. (For the last few days I worked with a hybrid control theme. I copied the gtk-3 directory from Mint-X theme into CinnXP. ;) |
hi.
to you ( nikokrause)
yes i did just send you link for ylmfos 14.04 theme. you can test it
as well the new 3.10 cinnxp theme.
maybe you could send a pull request of your current version to
mintystark/starkmenu and. bluedxca93/starkmenu.
regards bluedxca93
|
Hey, unfortunatelly I changed all oft my code without git. I'm not very familiar with git and don't have the time to struggle with installing git right now. Anyway. For now I have just changed the font color in cinnamon.css as you recommened. Also I changed the background color of some boxes, so I have the blue color on the right not on the left. But these are changes of CinnXP. Not of Stark. My previor pull requests were fixes of StarkMenu. And my last changes I made, were all due to the colors of the menu to have it look more like XP. So I'm not sure if somebody wants this changes, cause the idea of StarkMenu is 7 not XP. If I fix something in StarkMenu in the future, I will for sure make a pull request. But for now I am to afraid to mess things up in git with things that are not in the interest of many people, who don't want to use StarkMenu with CinnXP. But if you are still interessed, I could send you my files per E-Mail. Maybe you could give me some tipps how I can fork this Menu the right way. Without messing Stark up, so people who are interessed could decide whether or not they want to use the fixed original Stark or my messed up with CinnXP. When I have more time in some months I'm going to give it a try to create a better XP menu. But for now, I'm good with StarkMenu with changed background color. |
Sorry, forget my answer before. Now I understand what you meant. I could't see the pull request button on the mobile phone. Pull request should now be there. |
hi
ok, send me them with mail. ([email protected])
or on gnome-look.org pm.
I'look and import your fixes not related to xp (mention your name of
course) and if you have a great name i do help you forking it
properly.
regards bluedxca93
|
@cinnamoner: all fixes related to stark I made, were to fix the two checkboxes "show places" and "show recent files", in the settings of the menu, cause they didn't worked. And I added a checkbox in the settings, so you are able to give the menu the path to you custom icon directory, if you check the box. And if you uncheck it, the icon goes back to default. These two changes are in my Repo. Isn't it possible two download it Form there? If not I will send you the file with these patches. Or have I forgotten something? |
@cinnamoner: If you want to experiment with the code: I use a very usefull shortcut in Linux Mint. After I made some changes to the code, I safe the file, reload Cinnamon with Ctrl+Alt+ESC and watch what happened. If I don't like it, I redo the changes. |
hi,
do
merge and test tmrw the pull request to.bluedxca93/ starkmenu .
regards bluedxca93
|
@bluedxca93: Sorry but I don't understand your last comment? Is this even a sentence? |
hi,
erm. not really i agree. damn mobile phone.
but well ive received the changes on stark menu as pull request and do
include them in bluedxca93/starkmenu.
perhaps more understandable this time.
regards bluedxca93
|
@cinnamoner: You can try my changes without messing git up.
That's all. |
Okay I did it. I'm pretty happy with it. The only downside is, that the menu "jumps" when I press the "All Applications" button and the "Favorites" button. (See pictures: Switch between them, then you see the jump.) But I can live with that. If someone knows the answer, I would be happy to hear the solution. But I won't work for the next few weeks/months on it (Takes too much time). |
You want to set real_width_of(.menu-favorites-box + "?quicklinks Difficult task, maybe set a min-width for menu-categories box. It depends on your font Ich denke , dass man beide Menüoptionen gleich aussehen lassen kann, wenn regards/mfg On Mon, Jan 11, 2016 at 1:12 PM, NikoKrause [email protected]
|
B.t.w. what font do you use? On Mon, Jan 11, 2016 at 1:47 PM, Frieder Saugschmerle <
|
Okay. I will give it a try in a few days. I didn't changed the font of StarkMenu. Don't know how to do it? Or is the font set in CinnXP? Didn't changed that either. |
@cinnamoner not changed anything regarding boxpointer in that patch.
|
@bluedxca93: There is a funtion often used in the applet.JS file: this.box = new St.BoxLayout({ style_class: "menu-application-box"}) The menu-application-box is set in the cinnamon.css of the actually used theme. if(style_class "starkmenu-application-box" exists in cinnamon.css) |
hi,
good question.
the problem is how to check that the css class does or doesnt exist.
maybe code sample is in configurable menu? don't know..
regards bluedxca93
|
i believe you could define a fixed setting in the applet css and then
overwrite that with theme css but that isn't what is asked here i
know.
|
Sorry I am not much help in this thread, but for the css question I would think you could apply both.
That way if "starkmenu-application-box" exists it should overwrite "menu-application-box", but if it doesn't exist then it would just default to "menu-application-box". |
Wouldn't say legend :) |
@cinnamoner: I could send you the files tomorrow. Do you also want the blue sidebar in nemo? Or just the StarkMenu to look like XP? |
@cinnamoner: No, I don't even know where to search for. I still have no answer from petruzzi4prez. And without any further hint or idea I will not throw more time away on this minor problem. Actually I some kind of learned to like the gray box. I will send you a ZIP file tomorrow, if you send me your mailaddress once again. But I habe to waren you. My XPStarkMenu looks pretty ugly with themes other than the one CinnXP theme you will get from me. But you can install the fixed Win7StarkMenu also (aside to my XPStarkMenu cause I changed the name) from bluedxcas93 or from my repository. This Menu will look great with every theme. Even with my changed CinnXP theme. |
@cinnamoner: Yes. There are 3 menus:
The third one isn't in a repo. Also I translated the third into german. Do you want to translate it back in english or should I send you an english version? |
@cinnamoner
no that wont work. why? cause even if it looks like it, it doesnt work
in the same way as windows.
to name a few practical differences important to a former xp user :
no drive c
desktop folder name translated.
ext4 instead of ntfs and symlinks
the media players and file managers
no working exact paint clone (altetnative kolourpaint).
executable files without fileending
different file structure and a real kernel.
grub
even a n00b realizes that very fast as other differences too. so be
careful. showing a xp user linux in whatevet version is good, but to
lie isn't.
most simpler xp apps running fast under wine( better than reactos, and
win7 if you don't need it).
|
Increasing compatibility to 2.8 by forking popupsubmenuitem and including earlier bugfixes from g to c menu for adaption to Cinnamon 2.8 port by hawstan.