fix: consistently return short_names from sanitize #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hinaloe fyi |
|
Looks good! I reproduced the issue with jest, but something is not good enough |
|
Awesome, thank you. I've turned your diff file into a PR here and given you credit as the author: #323 I ran your tests and they definitely reproduce the issue! So that's wonderful. Thanks for your help. :) |
hinaloe
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #308 I am just going to assume that we always need to return
short_nameshere. Admittedly, though, I haven't managed to write a Jest test to actually reproduce #308, nor can I prove that this is actually currently causing a bug. But it seems harmless to returnshort_nameshere.