Return skin emoji on search #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
reviewed
Mar 23, 2019
| this.emojis[id] = {} | ||
| for (let skinTone = 1; skinTone <= 6; skinTone++) { | ||
| this.emojis[id][skinTone] = getSanitizedData({id, skin: skinTone}, skinTone, this.set, this.data) | ||
| } |
There was a problem hiding this comment.
This could probably be smaller if it were an array, but an object of IDs 1-6 is fine
|
Awesome PR. The only small issue is that we need to run |
|
@nolanlawson hmm that's odd, I have prettier setup in my editor to format on save and looks like there is a prettier config in the repo, so would've thought it should've caught any issues 🤔 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns emojis with skin data using skin tone from store in searches.
This is useful when doing emoji search for an autocomplete component.
Previously it would just return the default emoji data for an emoji, but now we get the skin related data too depending on what skin tone is set in the store.
Split out from #250