-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MkTimeでNODE_ENV=production pnpm install; pnpm run buildすると Rollup failed to resolve import "chromatic/isChromatic" #10609
Labels
Comments
#10475 が原因 |
|
MkTime だけ一旦リバートしてよいかも |
でも仮想モジュールとかではないはずなので謎( |
とりあえず修正した |
NODE_ENV=production pnpm install; |
あー |
プロダクションビルド時に |
Viteでresolve.alias使うとかプラグイン作るとかするといけるとか |
replace({
'isChromatic()': JSON.stringify(false),
}) かな |
これやったら dev じゃない dependencies に含めても副作用なさそう |
4 tasks
tamaina
added a commit
that referenced
this issue
Apr 13, 2023
* perf: remove isChromatic on real build * revert: Revert #10475 in MkTime This reverts commit 7d11cf8. * @rollup/plugin-replace as dependencies * fix pnpm-lock,yaml --------- Co-authored-by: tamaina <[email protected]>
na2na-p
pushed a commit
to na2na-p/misskey
that referenced
this issue
May 10, 2023
…#10613) * perf: remove isChromatic on real build * revert: Revert misskey-dev#10475 in MkTime This reverts commit 7d11cf8. * @rollup/plugin-replace as dependencies * fix pnpm-lock,yaml --------- Co-authored-by: tamaina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: