Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): ノート検索ページのデザイン調整 #14780

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Oct 19, 2024

What

image

  • fix/tweak(frontend): 検索ページでユーザー名が長い場合はみ出る問題
  • enh: ホスト指定とユーザー指定を統合

Why

  • ユーザー指定するとローカル指定/サーバー指定が使えないので最初から分けるようにしたほうが自然

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 19, 2024
@kakkokari-gtyih kakkokari-gtyih changed the title Enh tweak search page enhance(frontend): 検索ページのホスト指定とユーザー指定を統合 Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 164 lines in your changes missing coverage. Please review.

Project coverage is 14.61%. Comparing base (6199139) to head (14b0ff5).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/search.note.vue 0.00% 160 Missing ⚠️
packages/frontend/src/pages/search.user.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14780       +/-   ##
============================================
- Coverage    42.17%   14.61%   -27.57%     
============================================
  Files         1611      771      -840     
  Lines       162210    68736    -93474     
  Branches      4062     1237     -2825     
============================================
- Hits         68416    10045    -58371     
+ Misses       93355    58271    -35084     
+ Partials       439      420       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review October 19, 2024 08:35
@kakkokari-gtyih
Copy link
Contributor Author

こfぬりくと解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih kakkokari-gtyih requested a review from syuilo January 8, 2025 22:58
@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 1, 2025
@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo
Copy link
Member

syuilo commented Feb 26, 2025

タイトルでは「統合」で、Whyには「分ける」とあるけどどっちが正しいかしら

@kakkokari-gtyih
Copy link
Contributor Author

タイトルでは「統合」で、Whyには「分ける」とあるけどどっちが正しいかしら

項目を分けて動線を統合(?)

@kakkokari-gtyih kakkokari-gtyih changed the title enhance(frontend): 検索ページのホスト指定とユーザー指定を統合 enhance(frontend): ノート検索ページのデザイン調整 Feb 26, 2025
@kakkokari-gtyih
Copy link
Contributor Author

ややこしいのでタイトル変えた

@mi-gh-maintainer mi-gh-maintainer bot merged commit da66079 into misskey-dev:develop Feb 27, 2025
22 of 23 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the enh-tweak-search-page branch February 27, 2025 03:11
@tai-cha
Copy link
Contributor

tai-cha commented Feb 27, 2025

2025.2.1に含まれたので試してみたけどユーザー指定検索はよく使うのに使うのに1クリックの手間が増えたのが地味に不便に感じる

harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Feb 27, 2025
* enhance(frontend): 検索ページのホスト指定とユーザー指定を統合する (misskey-dev#273)

(cherry picked from commit c79392c)

* fix

* 🎨

* Update Changelog

* Update Changelog

* refactor

---------

Co-authored-by: taiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

4 participants