Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(frontend): 投稿フォームの設定メニューを改良 #14804

Open
wants to merge 41 commits into
base: develop
Choose a base branch
from
Open

enhance(frontend): 投稿フォームの設定メニューを改良 #14804

wants to merge 41 commits into from
+360 −169

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • 投稿ボタン横の「リアクションの受け入れ」ボタンを消して「その他」ボタンにした
  • 「その他」のポップアップ内に・・・
    • 文字数カウントを復活させた
    • 「リアクションの受け入れ」メニューを入れた
    • 投稿フォームのリセットボタンを入れた

image

Why

Fix #14794
Fix #10785

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 20, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 36 lines in your changes missing coverage. Please review.

Project coverage is 14.70%. Comparing base (c63c346) to head (293c1fc).

Files with missing lines Patch % Lines
...es/frontend/src/components/MkPostFormOtherMenu.vue 0.00% 35 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop   #14804       +/-   ##
============================================
- Coverage    42.16%   14.70%   -27.47%     
============================================
  Files         1609      772      -837     
  Lines       162358    68907    -93451     
  Branches      3906     1238     -2668     
============================================
- Hits         68459    10132    -58327     
+ Misses       93451    58354    -35097     
+ Partials       448      421       -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

👀

@syuilo
Copy link
Member

syuilo commented Jan 19, 2025

スマホ画面とかでどのような表示になるかスクショあると嬉しいわね

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Jan 19, 2025 •
edited
Loading

drawer表示になる

image

@kakkokari-gtyih
Copy link
Contributor Author

これ、MenuItemの定義自体もMkPostForm側に寄せたほうがいいかもしれないわね

@kakkokari-gtyih
Copy link
Contributor Author

これ、MenuItemの定義自体もMkPostForm側に寄せたほうがいいかもしれないわね

done

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 1, 2025
@kakkokari-gtyih
Copy link
Contributor Author

CHANGELOG移動した

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

noridev added a commit to kokonect-link/cherrypick that referenced this pull request Feb 17, 2025
@noridev
enhance(frontend): 게시 양식 설정 메뉴 개선 (misskey-dev/misskey#14804)
2a6c738 
	- 입력한 내용을 초기화할 수 있음
	- 입력한 글자 수를 표시함
syuilo
syuilo reviewed Feb 26, 2025
View reviewed changes
packages/frontend/src/components/MkPostFormOtherMenu.vue
const modal = useTemplateRef('modal');

const props = defineProps<{
items: MenuItem[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

投稿フォームで使われることが確定しているのにitemsを受け入れる実装なのはどういう意図かしら

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

呼び出し元のコンテキストで関数を実行できるため（機能を増やすたびにemitを追加したりする必要がない）

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ふぅ～む

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あとはなにか追加するときに通常のpopupMenuと同じ書き方で対応できるので後々楽

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、もとのemitの残骸が残ってるのでそれは除去しなくては

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

した

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih kakkokari-gtyih modified the milestones: v2025.2.1, v2025.3.0 Feb 27, 2025
@noridev noridev mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo syuilo left review comments

Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
[実験中] 管理用
Status: Todo
Milestone
v2025.3.0
Development

Successfully merging this pull request may close these issues.

投稿フォームの入力内容をクリアするボタン 残り文字数表示
2 participants
@kakkokari-gtyih @syuilo