Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): リノート経由でノートの詳細情報を見るとき、クリップ一覧がappearNoteのものになるように #15417

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Feb 7, 2025

What

image

↑ここのクリップ一覧がappearNoteをもとに取得されるように

各種メニューから利用できる操作は全てappearNoteのものなので、クリップ一覧もappearNoteで取得したほうが良さそう

Why

見かけ上クリップ一覧が表示されない(=実際はリノートがクリップに含まれているかどうかを問い合わせているだけ)ことがある問題を修正

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 14.61%. Comparing base (a778a63) to head (36b6e4d).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/note.vue 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15417       +/-   ##
============================================
- Coverage    42.18%   14.61%   -27.57%     
============================================
  Files         1610      771      -839     
  Lines       162156    68628    -93528     
  Branches      4059     1235     -2824     
============================================
- Hits         68401    10029    -58372     
+ Misses       93316    58179    -35137     
+ Partials       439      420       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mi-gh-maintainer mi-gh-maintainer bot merged commit 28b4069 into misskey-dev:develop Feb 26, 2025
9 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-inconsistent-clip-info branch February 26, 2025 12:57
harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Feb 27, 2025
…ey-dev#15417)

* fix(frontend): リノート経由でノートの詳細情報を見るとき、クリップ一覧がappearNoteのものになるように

* Update Changelog

---------

Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants