Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): コントロールパネルのユーザ検索で入力された情報をページ遷移で損なわないように #15438

Merged

Conversation

samunohito
Copy link
Member

What

ユーザ検索のクエリをセッションストレージに保持し、ブラウザのタブが閉じられるまで保持するようにしました。
これにより、ユーザを選択するなどの画面遷移が発生してもクエリが揮発することが無くなります。

Why

fix #15437

Additional info (optional)

実際に動作確認済み

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 9, 2025
@samunohito samunohito marked this pull request as ready for review February 9, 2025 10:54
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 28.81356% with 42 lines in your changes missing coverage. Please review.

Project coverage is 14.62%. Comparing base (28b4069) to head (1c31b4f).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin/users.vue 0.00% 28 Missing ⚠️
packages/frontend/src/memory-storage.ts 57.14% 12 Missing ⚠️
packages/frontend/src/account.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15438       +/-   ##
============================================
- Coverage    42.15%   14.62%   -27.54%     
============================================
  Files         1610      772      -838     
  Lines       162158    68680    -93478     
  Branches      4041     1238     -2803     
============================================
- Hits         68363    10046    -58317     
+ Misses       93322    58214    -35108     
+ Partials       473      420       -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 11, 2025
@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Feb 15, 2025

  • アカウント切り替え・ログアウトのときにも手動で破棄したほうがいいかも
  • sessionStorageじゃなくて外部ファイルに変数を置いておく形にしてページ再読み込みで絶対クリアされるほうがいいかも

@samunohito
Copy link
Member Author

fixed
f69b2f1

@mi-gh-maintainer mi-gh-maintainer bot merged commit 15b0345 into misskey-dev:develop Feb 26, 2025
9 checks passed
Copy link

Thank you 🙏

harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Feb 27, 2025
…v#15438)

* enhance(frontend): コントロールパネルのユーザ検索で入力された情報をページ遷移で損なわないように

* sessionStorageよりも更に短命な方法で持つように変更

* add comment

---------

Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
3 participants