Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): send Delete activity of a note to users who renoted or replied to it #15554

Conversation

zyoshoka
Copy link
Contributor

What

フォロワーではないユーザーにリノートもしくは返信された場合にノートの Delete アクティビティが送られていない問題を修正します。

Why

#15548 の部分的な解決

Additional info (optional)

#15548 でも示されている、照会だけのケースについては解決が簡単ではなさそうなのでこの PR では修正を見送ります(テストだけ追加)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Feb 25, 2025
Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 28.94737% with 27 lines in your changes missing coverage. Please review.

Project coverage is 42.17%. Comparing base (20cc6d3) to head (d093dcf).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/NoteDeleteService.ts 15.78% 16 Missing ⚠️
...nd/src/core/activitypub/ApDeliverManagerService.ts 42.10% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15554      +/-   ##
===========================================
- Coverage    42.19%   42.17%   -0.03%     
===========================================
  Files         1609     1609              
  Lines       161929   161962      +33     
  Branches      3896     4037     +141     
===========================================
- Hits         68326    68305      -21     
- Misses       93132    93186      +54     
  Partials       471      471              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mi-gh-maintainer mi-gh-maintainer bot merged commit 389ec63 into misskey-dev:develop Feb 26, 2025
32 checks passed
Copy link

Thank you 🙏

@zyoshoka zyoshoka deleted the fix/backend/send-delete-to-users-renoted-or-replied branch February 26, 2025 00:50
harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Feb 26, 2025
…replied to it (misskey-dev#15554)

* fix(backend): send Delete activity of a note to users who renoted or replied to it

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant