Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(MFM): add parameters to rotate #8549

Closed
wants to merge 2 commits into from

Conversation

Johann150
Copy link
Contributor

What

The x and y parameters are added to the $[rotate ] MFM function rendering, analogous to the $[spin ] function.

Why

fix #8523

@ThatOneCalculator
Copy link
Contributor

Doing $[rotate.x or $[rotate.y just causes the thing being rotated to dissapear

Regular:
image

X:
image

Y:
image

@Johann150
Copy link
Contributor Author

Yes thats because the default angle is 90°. Since the letters do not have any depth and you are looking at them from the side, that is not suprising. Try changing the angle.

@ThatOneCalculator
Copy link
Contributor

Yes thats because the default angle is 90°. Since the letters do not have any depth and you are looking at them from the side, that is not suprising. Try changing the angle.

I can't seem to figure out the syntax, as $[rotate.x=70 doesn't work

@Johann150
Copy link
Contributor Author

The angle must be changed as before by the deg parameter, e.g. $[rotate.x,deg=45 a].

@ThatOneCalculator
Copy link
Contributor

sick

@ThatOneCalculator
Copy link
Contributor

My conclusion on this:

Does it look great? Not really.
Is it bad? No.
Could it possibly be used in some cool #mfmart? Maybe.
Should it be added? Yea, more MFM options imo is never really a bad thing

@futchitwo
Copy link
Contributor

futchitwo commented Apr 26, 2022

Note on compatibility with forking: In Groundpolis, rotateX and rotateY are preceded by perspective(128px). (But probably syuilo does not care about compatibility with forking.)
https://github.com/Groundpolis/Groundpolis/blob/4f9c4532f51604056b2999212f8ff8323f59c357/src/client/components/mfm.functions.ts#L118

PS: This comes from $[spin]

@Johann150
Copy link
Contributor Author

I think it would be a good idea to add here too:

without perspective it can cause strange empty space
image

with perspective(128px) it looks better in my opinion
image

@ThatOneCalculator
Copy link
Contributor

Very tiny bug(?): the start of text gets cut off in chat bubbles
image

@Johann150 Johann150 closed this Dec 4, 2022
@Johann150 Johann150 deleted the rotate-x-y branch December 4, 2022 01:17
@ThatOneCalculator
Copy link
Contributor

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(MFM) rotate関数のspin関数相当への機能拡張
3 participants