Add additional background for acrylic popups if backdrop-filter is unsupported #8671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThatOneCalculator
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Works great on https://stop.voring.me with Firefox 101.0.1 on Linux
|
Closing because of the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds an additional background layer if the
backdrop-filteris not supported.This fixes #7996
Screenshot:
Firefox 100.0 on Windows 11, no
backdrop-filtersupport:Microsoft Edge 101.0.1210.39 on Windows 11,
backdrop-filtersupportWhy
Reaction or chart popups are hardly readable on Firefox.
Additional info (optional)
This implementation is somewhat of a "hack". The clean solution would be introducing an additional theme color variable that generates a less transparent background color variant, but I'm not sure what the effects of adding/changing theme colors would be for...all the created themes, basically.
So, for clarity, this implementation just adds an
:afterelement via CSS only ifbackdrop-filteris not supported. It takes up the height/width of the element, places itself behind it and usesvar(--bg)at 75% transparency.