Conditionally save project.properties #3348
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were always saving project.properties every time we loaded a project, even when there are no changes. This is because the computed settings don't store the qualifiedName (package name, called "main") as well as the project name itself. We add them here before the comparison. Change-Id: I6b0e206dbef6bfc100c5c3ce89db1ca7395e17e0
jisqyv
added
pull request: needs review
affects: master
Is Still Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always saving project.properties every time we loaded a project, even when there are no changes. This is because the computed settings don't store the qualifiedName (package name, called "main") as well as the project name itself. We add them here before the comparison.
Change-Id: I6b0e206dbef6bfc100c5c3ce89db1ca7395e17e0
General items:
ant testspasses on my machine (except the Blockly Tests, which don't run on my machine, yet.)If your code changes how something works on the device (i.e., it affects the companion):
ucrucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
mastermasteras the baseWhat does this PR accomplish?
Reduces the I/O between the client and server by not saving project.properties when it really hasn't changed.
Description
Fixes # .
Resolves # .