Fix ability to add/remove entries from certain types of charts #3262 #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle labels via throwing NFE from within ChartData2D and BarChart
|
@cindyloo It looks like the bar chart tests are failing. Can you please take a look at that? |
|
@ewpatton we are now throwing the |
cindyloo
commented
Feb 21, 2025
appinventor/components/src/com/google/appinventor/components/runtime/ChartData2D.java
Outdated
Show resolved
Hide resolved
ewpatton
changed the title
| rawX, rawY); | ||
| "GetEntryFromTuple", | ||
| ErrorMessages.ERROR_INVALID_CHART_ENTRY_VALUES, | ||
| rawX, rawY); |
There was a problem hiding this comment.
Additional whitespace needs to be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle labels via throwing NFE from within ChartData2D and BarChart
General items:
ant testspasses on my machineFor all other changes:
mastermasteras the baseWhat does this PR accomplish?
Description
updating ChartData2D to work with both strings and numbers for the x value (coordinate or label). Works correctly with Pie and BarCharts.
Fixes # .
#3262
Resolves # .