Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive layout #930

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Responsive layout #930

wants to merge 1 commit into from

Conversation

Mariazeigler
Copy link

Fixed padding issue when window is resized

@alilleybrinker
Copy link
Collaborator

Hi Maria, I'm not sure what my-project is, but it should be removed from the commit history here. You should also squash the changes down to one commit. As-is, this commit would be one of the largest in the history of the Hipcheck repo, with more than 105,000 new lines of code and 1,394 files impacted, mostly new files.

Copy link
Collaborator

@alilleybrinker alilleybrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, plus a few on polishing the PR. To merge you'll need to:

  • Squash your commits down to one commit.
  • Modify the commit message to follow the Conventional Commits spec, probably a message like "fix: Correct padding at width changes on index"
  • Include a Signed-off-by entry in your commit by passing the --signoff or -s flag to git commit (can also modify the last commit with git commit --amend --signoff).

@@ -8,7 +8,7 @@
<title>{% block title %}Hipcheck{% endblock %}</title>
{% include "partials/head.tera.html" %}
</head>
<body class="bg-white dark:bg-neutral-900 {% block body_classes %}{% endblock %}">
<body class="bg-white dark:bg-neutral-900 {% block body_classes %}{% endblock %} px-4 md:px-8 lg:px-16">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don't think this is quite the right fix. If you look at the homepage, you'll see the navigation bar at the top is squeezed inward horizontally, and the blue "values" section, which previously spanned the width of the page, is now boxed in. I think these padding styles should only be applied to the section with the intro text and diagram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants