Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace typeof image !== 'undefined' && image !== null with !!image #21

Closed
davidzwa opened this issue May 2, 2022 · 3 comments
Closed

Replace typeof image !== 'undefined' && image !== null with !!image #21

davidzwa opened this issue May 2, 2022 · 3 comments
Assignees
@davidzwa
Milestone
0.1.0

Comments

@davidzwa
Copy link
Collaborator

davidzwa commented May 2, 2022

Null/undefined checks should not use undefined string equality. This is a thing of the past.

Expected Behavior

Replaced code will cover more than just undefined or null. It will also mark 0, '', as false. The new code does not tackle [], NaN (I think) as falsy.

Current Behavior

Unchanged

Possible Solution

Replaced code will cover more than just undefined or null.

Steps to Reproduce (for bugs)

.

Context

Developer knowledge
@mkevenaar mkevenaar added this to the 0.1.0 milestone May 2, 2022
@davidzwa
Copy link
Collaborator Author

davidzwa commented May 2, 2022

Might as well reduce welcome::execute with some nulldef util for more simplicity.

@davidzwa davidzwa mentioned this issue May 2, 2022
Merged
9 tasks
davidzwa added a commit to davidzwa/NickNelson that referenced this issue May 3, 2022
@davidzwa
(mkevenaar#21) apply decent nulldef or whitespace checks
b104d9d
@davidzwa davidzwa mentioned this issue May 3, 2022
Merged
9 tasks
mkevenaar added a commit that referenced this issue May 3, 2022
@mkevenaar
Merge pull request #27 from davidzwa/bugfix/21-cleanup-falsy-checks
8e519ea 
(#21) apply decent nulldef or whitespace checks
@davidzwa davidzwa closed this as completed May 3, 2022
@davidzwa
Copy link
Collaborator Author

davidzwa commented May 3, 2022

Closed in #27

@mkevenaar
Copy link
Owner

🎉 This issue has been resolved in version 0.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidzwa davidzwa

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@mkevenaar @davidzwa