Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add __round__ to the customized mpmath mpf class #43

Merged
merged 1 commit into from
Jun 4, 2024
Merged

add __round__ to the customized mpmath mpf class #43

merged 1 commit into from
Jun 4, 2024

Conversation

mmatera
Copy link

@mmatera mmatera commented Jun 4, 2024

This PR just add the __round__ method in sage.libs.mpmath.mpf class. This is necessary for compatibility with Mathics, and must fix sagemath#37395.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • [] I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe marked this pull request as ready for review June 4, 2024 17:20
@mkoeppe mkoeppe merged commit db6b902 into mkoeppe:mathics_reduce_to_pip Jun 4, 2024
4 checks passed
@mkoeppe
Copy link
Owner

mkoeppe commented Jun 4, 2024

Thanks!

mkoeppe pushed a commit that referenced this pull request Jun 22, 2024
@mmatera @mkoeppe
add __round__ to the customized mpmath lib (#43)
9f47522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmatera @mkoeppe