Fix mlperf inference docker run on Windows (#188)

* Fix docker run on windows, install-pip-package-for-mlc
mlcommons · Feb 5, 2025 · 39aff4a · 39aff4a
1 parent 0f838b3
commit 39aff4a
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 11 deletions.
diff --git a/script/app-mlperf-inference/meta.yaml b/script/app-mlperf-inference/meta.yaml
@@ -113,7 +113,7 @@ deps:
       - 'yes'
   - tags: get,mlperf,inference,utils
 
-  - tags: install,pip-package,for-cmind-python,_package.pandas
+  - tags: install,pip-package,for-mlc-python,_package.pandas
     enable_if_env:
       MLC_PROFILE_NVIDIA_POWER:
         - on

diff --git a/script/generate-mlperf-inference-submission/meta.yaml b/script/generate-mlperf-inference-submission/meta.yaml
@@ -17,7 +17,7 @@ deps:
   - inference-src
   tags: mlcommons,inference,src
 - tags: get,sut,system-description
-- tags: install,pip-package,for-cmind-python,_package.tabulate
+- tags: install,pip-package,for-mlc-python,_package.tabulate
 - tags: get,mlperf,inference,utils
 - names:
   - get-mlperf-results-dir

diff --git a/script/install-pip-package-for-cmind-python/README.md b/script/install-pip-package-for-cmind-python/README.md
diff --git a/...pip-package-for-cmind-python/COPYRIGHT.md → ...l-pip-package-for-mlc-python/COPYRIGHT.md b/...pip-package-for-cmind-python/COPYRIGHT.md → ...l-pip-package-for-mlc-python/COPYRIGHT.md
diff --git a/...pip-package-for-cmind-python/customize.py → ...l-pip-package-for-mlc-python/customize.py b/...pip-package-for-cmind-python/customize.py → ...l-pip-package-for-mlc-python/customize.py
diff --git a/...ll-pip-package-for-cmind-python/meta.yaml → ...tall-pip-package-for-mlc-python/meta.yaml b/...ll-pip-package-for-cmind-python/meta.yaml → ...tall-pip-package-for-mlc-python/meta.yaml
@@ -1,4 +1,4 @@
-alias: install-pip-package-for-cmind-python
+alias: install-pip-package-for-mlc-python
 automation_alias: script
 automation_uid: 5b4e0237da074764
 cache: true
@@ -7,8 +7,8 @@ tags:
 - pip
 - package
 - pip-package
-- for-cmind-python
-- for.cmind-python
+- for-mlc-python
+- for.mlc-python
 uid: b16ed087abab459c
 
 variations:

diff --git a/script/run-docker-container/customize.py b/script/run-docker-container/customize.py
@@ -160,7 +160,8 @@ def postprocess(i):
         for mounts in env['MLC_DOCKER_VOLUME_MOUNTS']:
             mount_cmds.append(mounts)
 
-    if env.get('MLC_DOCKER_PASS_USER_GROUP', '') != '':
+    if env.get('MLC_DOCKER_PASS_USER_GROUP',
+               '') != '' and os_info['platform'] != 'windows':
         run_opts += " --group-add $(id -g $USER) "
 
     if env.get('MLC_DOCKER_ADD_DEVICE', '') != '':

diff --git a/script/run-mlperf-automotive-app/meta.yaml b/script/run-mlperf-automotive-app/meta.yaml
@@ -120,7 +120,7 @@ deps:
     MLC_MLPERF_USE_DOCKER: [ off ]
   skip_if_env:
     OUTPUT_BASE_DIR: [ on ]
-- tags: install,pip-package,for-cmind-python,_package.tabulate
+- tags: install,pip-package,for-mlc-python,_package.tabulate
 - tags: get,mlperf,inference,utils
   skip_if_env:
     MLC_MLPERF_USE_DOCKER: [ on ]

diff --git a/script/run-mlperf-inference-app/meta.yaml b/script/run-mlperf-inference-app/meta.yaml
@@ -156,11 +156,9 @@ deps:
 - tags: get,mlperf,inference,results,dir
   names:
     - get-mlperf-inference-results-dir
-  enable_if_env:
-    MLC_MLPERF_USE_DOCKER: [ off ]
   skip_if_env:
     OUTPUT_BASE_DIR: [ on ]
-- tags: install,pip-package,for-cmind-python,_package.tabulate
+- tags: install,pip-package,for-mlc-python,_package.tabulate
 - tags: get,mlperf,inference,utils
 
 #We use this script as a command generator to run docker via app-mlperf-inference script