Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: validate the .pbtxt files in the build step #967

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

anhappdev
Copy link
Collaborator

@anhappdev anhappdev commented Feb 22, 2025

We've introduced a new command (make lint/pbtxt) to validate our .pbtxt files. This command will help us identify common errors such as missing commas, curly braces, double quotes, or incorrect field names. The linter will automatically be triggered during our CI process.

Copy link

github-actions bot commented Feb 22, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anhappdev anhappdev marked this pull request as ready for review February 23, 2025 11:23
@anhappdev anhappdev requested a review from a team as a code owner February 23, 2025 11:23
@anhappdev anhappdev merged commit 1be3f66 into master Feb 25, 2025
26 checks passed
@anhappdev anhappdev deleted the anh/validate-pbtxt branch February 25, 2025 06:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate the .pbtxt files in the build step
2 participants