-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSDocs to everything #56
Conversation
@aryaemami59 thanks so much, this is great! I am planning on releasing v1 very soon, so this will be great to have. I've read through these and they look very helpful and well-written to me. I might look to tweak them/see if some of the examples can be auto-generated to make sure they stay up to date, but this is a fantastic starting point. There's a small conflict in |
@mmkal thank you, I will resolve the conflicts, not sure if there was anything else I wanted to add but I'm going to mark at as ready and if I can think of anything else to add, I'll open up a separate PR. |
@mmkal Please let me know if there is anything you want me to change. I'd be happy to do it. |
@aryaemami59 took a closer look through and some changes I think in a couple of cases these can be trimmed down a little bit. I would prefer to only have jsdoc that adds helpful, non-obvious information, rather than have 100% doc coverage. If it's repeating information that can be gleaned from the type/value itself, it risks drifting from the implementation it mirrors, as well as being noisy in the meantime. So:
The ones on the methods that are part of the public API are super useful. Thanks again! |
@mmkal Sounds good, I will make the requested adjustments. Thanks for the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍 👍 👍
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [expect-type](https://togithub.com/mmkal/expect-type) | [`0.18.0` -> `0.19.0`](https://renovatebot.com/diffs/npm/expect-type/0.18.0/0.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mmkal/expect-type (expect-type)</summary> ### [`v0.19.0`](https://togithub.com/mmkal/expect-type/releases/tag/0.19.0) [Compare Source](https://togithub.com/mmkal/expect-type/compare/0.18.0...0.19.0) #### What's Changed - Fix `.omit()` to work similarly to `Omit` by [@​aryaemami59](https://togithub.com/aryaemami59) in [https://github.com/mmkal/expect-type/pull/54](https://togithub.com/mmkal/expect-type/pull/54) - Add JSDocs to everything by [@​aryaemami59](https://togithub.com/aryaemami59) in [https://github.com/mmkal/expect-type/pull/56](https://togithub.com/mmkal/expect-type/pull/56) - Remove `test` import in `README.md` by [@​aryaemami59](https://togithub.com/aryaemami59) in [https://github.com/mmkal/expect-type/pull/65](https://togithub.com/mmkal/expect-type/pull/65) **Full Changelog**: mmkal/expect-type@0.18.0...0.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
This PR: