Add alloc_with_options #1218
Open
Add alloc_with_options #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wks
reviewed
Oct 30, 2024
|
I changed the documentation based on the suggestions. |
k-sareen
reviewed
Oct 30, 2024
src/memory_manager.rs
Outdated
| /// normally without panicking or throwing exceptions, this function will return zero. | ||
| /// | ||
| /// This function in most cases returns a valid memory address. | ||
| /// This function may return a zero address iif 1. MMTk attempts at least one GC, |
There was a problem hiding this comment.
Suggested change
| /// This function may return a zero address iif 1. MMTk attempts at least one GC, | |
| /// This function may return a zero address if 1. MMTk attempts at least one GC, |
There was a problem hiding this comment.
Actually this paragraph should be removed.
large object. Minor fixes for comments
wks
reviewed
Oct 31, 2024
wks
reviewed
Oct 31, 2024
Co-authored-by: Kunshan Wang <[email protected]>
|
I’m awaiting feedback from @JunmingZhao42 and Ben before merging this PR, as they requested this feature. |
bgamari
reviewed
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an alternative allocation functions
alloc_with_options. The attachedAllocationOptionschange the allocation behavior, such as avoiding GCs and allowing overcommit.Our current
allocfunctions assume they are GC safe points and will trigger GCs internally. A runtime may have different assumptions. We see GHC hasallocateMightFail(https://gitlab.haskell.org/ghc/ghc/-/blob/90746a591919fc51a0ec9dec58d8f1c8397040e3/rts/sm/Storage.c?page=2#L1089). Also Julia assumes perm alloc will not trigger a GC (mmtk/mmtk-julia#172).Having a variant of
allocthat is not GC safepoints could be generally useful.